[PATCH 1/1] repoman: deprecate netsurf.eclass.

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH 1/1] repoman: deprecate netsurf.eclass.

Michael Orlitzky
While investigating bug 489542, it became clear that the netsurf
eclass is deprecated in spirit if not in fact. All of the newer
netsurf ebuilds use a custom function loaded from a script that is
shipped in netsurf-buildsystem's $FILESDIR to do (some of) what the
eclass used to do. That function probably does belong in an eclass,
but at this point, we should throw this thing out and start from
scratch.

By deprecating the eclass, we make sure that no one else inherits it
during the time it takes to purge the two remaining consumers. Then,
once those are gone, the build system script magic can be put back
into an eclass, and its consumers updated one-at-a-time.

Bug: https://bugs.gentoo.org/489542
Bug: https://bugs.gentoo.org/637824
Signed-off-by: Michael Orlitzky <[hidden email]>
---
 repoman/lib/repoman/modules/linechecks/deprecated/inherit.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/repoman/lib/repoman/modules/linechecks/deprecated/inherit.py b/repoman/lib/repoman/modules/linechecks/deprecated/inherit.py
index 5848a0c37..60410347b 100644
--- a/repoman/lib/repoman/modules/linechecks/deprecated/inherit.py
+++ b/repoman/lib/repoman/modules/linechecks/deprecated/inherit.py
@@ -33,6 +33,7 @@ class InheritDeprecated(LineCheck):
  "gst-plugins10": "gstreamer",
  "ltprune": False,
  "mono": "mono-env",
+ "netsurf": False,
  "python": "python-r1 / python-single-r1 / python-any-r1",
  "ruby": "ruby-ng",
  "user": "GLEP 81",
--
2.26.2


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 1/1] repoman: deprecate netsurf.eclass.

Zac Medico-2
On 6/16/20 10:36 AM, Michael Orlitzky wrote:

> While investigating bug 489542, it became clear that the netsurf
> eclass is deprecated in spirit if not in fact. All of the newer
> netsurf ebuilds use a custom function loaded from a script that is
> shipped in netsurf-buildsystem's $FILESDIR to do (some of) what the
> eclass used to do. That function probably does belong in an eclass,
> but at this point, we should throw this thing out and start from
> scratch.
>
> By deprecating the eclass, we make sure that no one else inherits it
> during the time it takes to purge the two remaining consumers. Then,
> once those are gone, the build system script magic can be put back
> into an eclass, and its consumers updated one-at-a-time.
>
> Bug: https://bugs.gentoo.org/489542
> Bug: https://bugs.gentoo.org/637824
> Signed-off-by: Michael Orlitzky <[hidden email]>
> ---
>  repoman/lib/repoman/modules/linechecks/deprecated/inherit.py | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/repoman/lib/repoman/modules/linechecks/deprecated/inherit.py b/repoman/lib/repoman/modules/linechecks/deprecated/inherit.py
> index 5848a0c37..60410347b 100644
> --- a/repoman/lib/repoman/modules/linechecks/deprecated/inherit.py
> +++ b/repoman/lib/repoman/modules/linechecks/deprecated/inherit.py
> @@ -33,6 +33,7 @@ class InheritDeprecated(LineCheck):
>   "gst-plugins10": "gstreamer",
>   "ltprune": False,
>   "mono": "mono-env",
> + "netsurf": False,
>   "python": "python-r1 / python-single-r1 / python-any-r1",
>   "ruby": "ruby-ng",
>   "user": "GLEP 81",
>
Thanks, applied:

https://gitweb.gentoo.org/proj/portage.git/commit/?id=a73024729860f9224b8d1660d24c450080b67d9f
--
Thanks,
Zac


signature.asc (1000 bytes) Download Attachment