[PATCH] doman: QA-complain on compressed files

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] doman: QA-complain on compressed files

Michał Górny-5
Passing compressed files to doman is not permitted by the PMS. However,
Portage permitting it results in many developers repeatedly violating
this and arguing that it's permitted because nobody explicitly forbids
it. Add an explicit QA warning to Portage to cease it.
---
 bin/ebuild-helpers/doman | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bin/ebuild-helpers/doman b/bin/ebuild-helpers/doman
index da66ac335..43d29f22e 100755
--- a/bin/ebuild-helpers/doman
+++ b/bin/ebuild-helpers/doman
@@ -30,6 +30,7 @@ for x in "$@" ; do
 
  # These will be automatically decompressed by ecompressdir.
  if has ${suffix} Z gz bz2 ; then
+ eqawarn "QA Notice: doman argument '${x}' is compressed, this is not portable"
  realname=${x%.*}
  suffix=${realname##*.}
  fi
--
2.13.2


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] doman: QA-complain on compressed files

Brian Dolbec-3
On Sun,  2 Jul 2017 19:57:57 +0200
Michał Górny <[hidden email]> wrote:

> Passing compressed files to doman is not permitted by the PMS.
> However, Portage permitting it results in many developers repeatedly
> violating this and arguing that it's permitted because nobody
> explicitly forbids it. Add an explicit QA warning to Portage to cease
> it. ---
>  bin/ebuild-helpers/doman | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/bin/ebuild-helpers/doman b/bin/ebuild-helpers/doman
> index da66ac335..43d29f22e 100755
> --- a/bin/ebuild-helpers/doman
> +++ b/bin/ebuild-helpers/doman
> @@ -30,6 +30,7 @@ for x in "$@" ; do
>  
>   # These will be automatically decompressed by ecompressdir.
>   if has ${suffix} Z gz bz2 ; then
> + eqawarn "QA Notice: doman argument '${x}' is
> compressed, this is not portable" realname=${x%.*}
>   suffix=${realname##*.}
>   fi

sounds good

--
Brian Dolbec <dolsen>


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] doman: QA-complain on compressed files

Michał Górny-5
On nie, 2017-07-02 at 11:57 -0700, Brian Dolbec wrote:

> On Sun,  2 Jul 2017 19:57:57 +0200
> Michał Górny <[hidden email]> wrote:
>
> > Passing compressed files to doman is not permitted by the PMS.
> > However, Portage permitting it results in many developers repeatedly
> > violating this and arguing that it's permitted because nobody
> > explicitly forbids it. Add an explicit QA warning to Portage to cease
> > it. ---
> >  bin/ebuild-helpers/doman | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/bin/ebuild-helpers/doman b/bin/ebuild-helpers/doman
> > index da66ac335..43d29f22e 100755
> > --- a/bin/ebuild-helpers/doman
> > +++ b/bin/ebuild-helpers/doman
> > @@ -30,6 +30,7 @@ for x in "$@" ; do
> >  
> >   # These will be automatically decompressed by ecompressdir.
> >   if has ${suffix} Z gz bz2 ; then
> > + eqawarn "QA Notice: doman argument '${x}' is
> > compressed, this is not portable" realname=${x%.*}
> >   suffix=${realname##*.}
> >   fi
>
> sounds good
>
Merged.

--
Best regards,
Michał Górny

signature.asc (1007 bytes) Download Attachment