[PATCH] repoman: Update --bug/--closes description for bugs.g.o hooks

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] repoman: Update --bug/--closes description for bugs.g.o hooks

Michał Górny-5
Update the description for --bug and --closes to account for the fact
that the tags are now handled by git hooks on Gentoo Infra, and cause
actions on Gentoo Bugzilla.

// NB: It would probably make sense for --closes to default to Gentoo
bug numbers now. However, I have doubts that some people might have
already started using it for pull requests, and that might cause
confusion. What do you think?
---
 repoman/man/repoman.1 | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/repoman/man/repoman.1 b/repoman/man/repoman.1
index a49c72c0d..4b518e6f1 100644
--- a/repoman/man/repoman.1
+++ b/repoman/man/repoman.1
@@ -27,13 +27,16 @@ be either a Gentoo bug number or a full bug URL (either Gentoo
 or upstream). Gentoo bug URLs are automatically shortened to
 the canonical \fBhttps://bugs.gentoo.org/NNNNNN\fR form, and HTTPS
 is forced for known bug trackers.
+
+When pushing to the Gentoo repository, the reference to the commit
+will be automatically added as a comment on the bug.
 .TP
 \fB-c\fR, \fB--closes\fR
 Include a \fBCloses\fR tag in the commit message footer that can be used
-to close pull requests (and issues) on GitHub and other compatible
-services (GitLab, Bitbucket). The argument can be either a PR number for
-the gentoo/gentoo GitHub repository or a full PR/bug URL. For bug URLs,
-HTTPS is forced automatically for known bug/PR trackers.
+to close bugs and pull requests (e.g. on Gentoo Bugzilla, GitHub, GitLab,
+Bitbucket). The argument can be either a PR number for the gentoo/gentoo
+GitHub repository or a full PR/bug URL. For bug URLs, HTTPS is forced
+automatically for known bug/PR trackers.
 .TP
 \fB\-\-digest=<y|n>\fR
 Automatically update Manifest digests for modified files. This
--
2.14.1


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] repoman: Update --bug/--closes description for bugs.g.o hooks

Zac Medico-2
On 09/02/2017 12:10 PM, Michał Górny wrote:
> Update the description for --bug and --closes to account for the fact
> that the tags are now handled by git hooks on Gentoo Infra, and cause
> actions on Gentoo Bugzilla.
>
> // NB: It would probably make sense for --closes to default to Gentoo
> bug numbers now. However, I have doubts that some people might have
> already started using it for pull requests, and that might cause
> confusion. What do you think?

Yeah it's hard do say, maybe add a --closes-bug option for gentoo bugs?

> ---
>  repoman/man/repoman.1 | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/repoman/man/repoman.1 b/repoman/man/repoman.1
> index a49c72c0d..4b518e6f1 100644
> --- a/repoman/man/repoman.1
> +++ b/repoman/man/repoman.1
> @@ -27,13 +27,16 @@ be either a Gentoo bug number or a full bug URL (either Gentoo
>  or upstream). Gentoo bug URLs are automatically shortened to
>  the canonical \fBhttps://bugs.gentoo.org/NNNNNN\fR form, and HTTPS
>  is forced for known bug trackers.
> +
> +When pushing to the Gentoo repository, the reference to the commit
> +will be automatically added as a comment on the bug.
>  .TP
>  \fB-c\fR, \fB--closes\fR
>  Include a \fBCloses\fR tag in the commit message footer that can be used
> -to close pull requests (and issues) on GitHub and other compatible
> -services (GitLab, Bitbucket). The argument can be either a PR number for
> -the gentoo/gentoo GitHub repository or a full PR/bug URL. For bug URLs,
> -HTTPS is forced automatically for known bug/PR trackers.
> +to close bugs and pull requests (e.g. on Gentoo Bugzilla, GitHub, GitLab,
> +Bitbucket). The argument can be either a PR number for the gentoo/gentoo
> +GitHub repository or a full PR/bug URL. For bug URLs, HTTPS is forced
> +automatically for known bug/PR trackers.
>  .TP
>  \fB\-\-digest=<y|n>\fR
>  Automatically update Manifest digests for modified files. This
>

Looks good.
--
Thanks,
Zac

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] repoman: Update --bug/--closes description for bugs.g.o hooks

Michał Górny-5
W dniu sob, 02.09.2017 o godzinie 14∶33 -0700, użytkownik Zac Medico
napisał:

> On 09/02/2017 12:10 PM, Michał Górny wrote:
> > Update the description for --bug and --closes to account for the fact
> > that the tags are now handled by git hooks on Gentoo Infra, and cause
> > actions on Gentoo Bugzilla.
> >
> > // NB: It would probably make sense for --closes to default to Gentoo
> > bug numbers now. However, I have doubts that some people might have
> > already started using it for pull requests, and that might cause
> > confusion. What do you think?
>
> Yeah it's hard do say, maybe add a --closes-bug option for gentoo bugs?
>

I'm going to ask around. Thinking about it, having pull request closing
in repoman doesn't seem really useful. After all, people normally commit
stuff before creating a pull request, and so they don't have the pull
request number yet. And when they do, they rather 'git commit --amend'
after all.

--
Best regards,
Michał Górny