Question I had while writing my devmanual patch about eclasses

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Question I had while writing my devmanual patch about eclasses

Thomas Anderson-10
While writing the devmanual patch that I agreed to write for removal of
eclasses I came across the very vague definition of "deprecating"
eclasses before removal. Ulrich(last name ommitted to avoid stabbing ;-) )
and we came up with the following for the process of deprecating an
eclass:

a. make sure nothing in the tree uses it any more
b. announce deprecation on -dev
c. put a warning in pkg_setup
d. add a line containing exactly "# @DEAD" for vapier's man pages

Please vote so we don't have to go over this in a meeting. I personally
am fine with it, but my vote matters little.

--
---------
Thomas Anderson
Gentoo Developer
/////////
Areas of responsibility:
AMD64, Secretary to the Gentoo Council
---------

attachment0 (204 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Question I had while writing my devmanual patch about eclasses

Tobias Scherbaum
Thomas Anderson wrote:
> a. make sure nothing in the tree uses it any more
> b. announce deprecation on -dev
> c. put a warning in pkg_setup
> d. add a line containing exactly "# @DEAD" for vapier's man pages

Looks good to me.

Tobias

signature.asc (205 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Question I had while writing my devmanual patch about eclasses

Torsten Veller
In reply to this post by Thomas Anderson-10
* Thomas Anderson <[hidden email]>:
> c. put a warning in pkg_setup

pkg_setup is probably not exported.
Even if it gets exported, we can't be sure that it is run.

If we want to warn on future installations, we better put the
warning in all installation phases.

Reply | Threaded
Open this post in threaded view
|

Re: Question I had while writing my devmanual patch about eclasses

Tiziano Müller-3
In reply to this post by Thomas Anderson-10
Am Donnerstag, den 04.06.2009, 19:01 -0400 schrieb Thomas Anderson:

> While writing the devmanual patch that I agreed to write for removal of
> eclasses I came across the very vague definition of "deprecating"
> eclasses before removal. Ulrich(last name ommitted to avoid stabbing ;-) )
> and we came up with the following for the process of deprecating an
> eclass:
>
> a. make sure nothing in the tree uses it any more
> b. announce deprecation on -dev
> c. put a warning in pkg_setup
> d. add a line containing exactly "# @DEAD" for vapier's man pages
>
> Please vote so we don't have to go over this in a meeting. I personally
> am fine with it, but my vote matters little.
According to the above you applied Common Sense (tm) which would have
been sufficient, but since you ask: yes, I think it looks ok.
We may want to create an additional deprecated.eclass where we implement
pkg_setup (and maybe pkg_pretend for eapi-3) to have a default "this is
deprecated" warning and die-statement.

Cheers,
Tiziano


--
Tiziano Müller
Gentoo Linux Developer, Council Member
Areas of responsibility:
  Samba, PostgreSQL, CPP, Python, sysadmin, GLEP Editor
E-Mail   : [hidden email]
GnuPG FP : F327 283A E769 2E36 18D5  4DE2 1B05 6A63 AE9C 1E30

signature.asc (205 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Question I had while writing my devmanual patch about eclasses

Petteri Räty-2
In reply to this post by Thomas Anderson-10
Thomas Anderson wrote:
> While writing the devmanual patch that I agreed to write for removal of
> eclasses I came across the very vague definition of "deprecating"
> eclasses before removal. Ulrich(last name ommitted to avoid stabbing ;-) )
> and we came up with the following for the process of deprecating an
> eclass:
>
> a. make sure nothing in the tree uses it any more
> b. announce deprecation on -dev

-dev-announce

> c. put a warning in pkg_setup

Could make use of what debug.eclass does now.


Regards,
Petteri


signature.asc (269 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Question I had while writing my devmanual patch about eclasses

Doug Goldstein
In reply to this post by Thomas Anderson-10
On Thu, Jun 4, 2009 at 6:01 PM, Thomas Anderson<[hidden email]> wrote:

> While writing the devmanual patch that I agreed to write for removal of
> eclasses I came across the very vague definition of "deprecating"
> eclasses before removal. Ulrich(last name ommitted to avoid stabbing ;-) )
> and we came up with the following for the process of deprecating an
> eclass:
>
> a. make sure nothing in the tree uses it any more
> b. announce deprecation on -dev
> c. put a warning in pkg_setup
> d. add a line containing exactly "# @DEAD" for vapier's man pages
>
> Please vote so we don't have to go over this in a meeting. I personally
> am fine with it, but my vote matters little.
>
> --
> ---------
> Thomas Anderson
> Gentoo Developer
> /////////
> Areas of responsibility:
> AMD64, Secretary to the Gentoo Council
> ---------
>

Looks good from here. ++

--
Doug Goldstein