Re: [PATCH] fix modpost when CONFIG_ALPHA_TSUNAMI=y

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] fix modpost when CONFIG_ALPHA_TSUNAMI=y

Jim Faulkner
Hi Matt,

I see that you're one of the maintainers of the alpha architecture in
the Linux kernel.  Compiling with CONFIG_ALPHA_TSUNAMI=y has been broken
for a while, and the fix seems simple.  Is there any chance you can sign
off on the patch I proposed on Feb 18?  Or is there a better solution
for this build problem?


On Sat, Feb 18, 2012 at 05:39:57PM -0500, Jim Faulkner wrote:

> On Sun, Feb 19, 2012 at 11:29:34AM +1300, Michael Cree wrote:
> > >  
> > > +#include <linux/module.h>
> >
> > Wouldn't <linux/exports.h> be better?  I seem to recall that this was a
> > problem with EXPORT_SYMBOL not being defined and I see my own personal
> > fix (which I had completely forgotten to send upstream) was to include
> > <linux/exports.h>
>
> core_marvel.c and core_titan.c both include <linux/module.h> in the
> mainline kernel, which is why I thought it was the appropriate fix for
> core_tsunami.c.
>