Re: [gentoo-commits] gentoo-x86 commit in net-libs/libmnl: libmnl-1.0.1.ebuild ChangeLog

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [gentoo-commits] gentoo-x86 commit in net-libs/libmnl: libmnl-1.0.1.ebuild ChangeLog

pva0xd
В Вск, 01/05/2011 в 12:25 +0000, Fabian Groffen (grobian) пишет:
> grobian     11/05/01 12:25:59

>   Fix econf call for Prefix: don't mix Prefix compatible and incompatible code

>  src_configure() {
>   econf \
> - --libdir=/$(get_libdir)
> + --libdir="${EPREFIX}"/$(get_libdir)
>  }

Could you clarify this bit, please? Should we use ED, EPREFIX, ... in
EAPI>=3 or we just ignore it and write ebuilds as always until prefix
team ports them and adds keywords?

--
Peter.


Reply | Threaded
Open this post in threaded view
|

Re: Re: [gentoo-commits] gentoo-x86 commit in net-libs/libmnl: libmnl-1.0.1.ebuild ChangeLog

Fabian Groffen-2
On 01-05-2011 17:04:18 +0400, Peter Volkov wrote:

> В Вск, 01/05/2011 в 12:25 +0000, Fabian Groffen (grobian) пишет:
> > grobian     11/05/01 12:25:59
>
> >   Fix econf call for Prefix: don't mix Prefix compatible and incompatible code
>
> >  src_configure() {
> >   econf \
> > - --libdir=/$(get_libdir)
> > + --libdir="${EPREFIX}"/$(get_libdir)
> >  }
>
> Could you clarify this bit, please? Should we use ED, EPREFIX, ... in
> EAPI>=3 or we just ignore it and write ebuilds as always until prefix
> team ports them and adds keywords?

In short: yes, if you don't know what Prefix is, how it works or what
exactly needs to be done, you can ignore it.
You are always free to ask any team member in case you like to
understand it and/or get it right.

I added the ${EPREFIX} part to the econf call, because you do use ${ED}
lateron in src_install() of the ebuild.

The agreed "rules" are that an >=EAPI-3 ebuild does not have to support
offset installs, but that such support can/may be added (by e.g. the
Prefix team).

In this case the ebuild was half/half, which causes needless bugs with
confusing descriptions, and it caught my eye, so I just took the liberty
to fix it, even though the ebuild does not report to be in use for any
Prefix arch at the moment.


--
Fabian Groffen
Gentoo on a different level