Re: java-dep-check on ant tasks

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: java-dep-check on ant tasks

Vlastimil Babka-2
On 01/19/2011 04:03 PM, "Miroslav Šulc (fordfrog)" wrote:
> hi,
>
> i was looking at the issues when some classes cannot be found via
> DEPENDS, like http://bugs.gentoo.org/show_bug.cgi?id=298689. the problem
> is that DEPENDS for ant tasks does not contain dependency on ant-core.
> this patch below could fix it (at least it fixed the issue for me and
> testing some junit ant tasks while emerging packages with
> FEATURES="test" worked too):

This could work for ant-tasks themselves, but not for everything else
that has ant-core dependency, such as when a package provides some ant
task. In that case, the depending classes are needed only when invoked
from within ant, in which case they are already on classpath.
Registering as dependency would make ant put on classpath in all cases
the package is used.
The bottom line is, there should be a way to exclude stuff (such as ant
classes) in java-dep-check.

BTW, the mailing list is better than the java alias for this. Seems to
get much less spam as I see it :)

Vlastimil

> $ cvs diff ant-tasks.eclass
> Index: ant-tasks.eclass
> ===================================================================
> RCS file: /var/cvsroot/gentoo-x86/eclass/ant-tasks.eclass,v
> retrieving revision 1.8
> diff -r1.8 ant-tasks.eclass
> 174a176
>>      java-pkg_register-dependency ant-core ant.jar
>
> any objections against committing this?
>
> miroslav


Reply | Threaded
Open this post in threaded view
|

Re: Re: java-dep-check on ant tasks

"Miroslav Šulc (fordfrog)"
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dne 31.1.2011 02:14, Vlastimil Babka napsal(a):

> On 01/19/2011 04:03 PM, "Miroslav Šulc (fordfrog)" wrote:
>> hi,
>>
>> i was looking at the issues when some classes cannot be found via
>> DEPENDS, like http://bugs.gentoo.org/show_bug.cgi?id=298689. the problem
>> is that DEPENDS for ant tasks does not contain dependency on ant-core.
>> this patch below could fix it (at least it fixed the issue for me and
>> testing some junit ant tasks while emerging packages with
>> FEATURES="test" worked too):
>
> This could work for ant-tasks themselves, but not for everything else
> that has ant-core dependency, such as when a package provides some ant
> task. In that case, the depending classes are needed only when invoked
> from within ant, in which case they are already on classpath.
> Registering as dependency would make ant put on classpath in all cases
> the package is used.
> The bottom line is, there should be a way to exclude stuff (such as ant
> classes) in java-dep-check.

well, imo there is a question when to exclude and when not, talking
generally, not just about ant classes.

>
> BTW, the mailing list is better than the java alias for this. Seems to
> get much less spam as I see it :)
>
> Vlastimil

miroslav
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk1GE94ACgkQB6q7Q15RwyDA8ACggSjonL0CUxL1zfKOA7zB8E/m
nI4Anjocpsd1vVs6H4gQVQarblYJSFrN
=N6u7
-----END PGP SIGNATURE-----

Reply | Threaded
Open this post in threaded view
|

Re: Re: java-dep-check on ant tasks

Alistair Bush-2
> Dne 31.1.2011 02:14, Vlastimil Babka napsal(a):
> > On 01/19/2011 04:03 PM, "Miroslav Šulc (fordfrog)" wrote:
> >> hi,
> >>
> >> i was looking at the issues when some classes cannot be found via
> >> DEPENDS, like http://bugs.gentoo.org/show_bug.cgi?id=298689. the problem
> >> is that DEPENDS for ant tasks does not contain dependency on ant-core.
> >> this patch below could fix it (at least it fixed the issue for me and
> >> testing some junit ant tasks while emerging packages with
> >
> >> FEATURES="test" worked too):
> > This could work for ant-tasks themselves, but not for everything else
> > that has ant-core dependency, such as when a package provides some ant
> > task. In that case, the depending classes are needed only when invoked
> > from within ant, in which case they are already on classpath.
> > Registering as dependency would make ant put on classpath in all cases
> > the package is used.
> > The bottom line is, there should be a way to exclude stuff (such as ant
> > classes) in java-dep-check.
>
> well, imo there is a question when to exclude and when not, talking
> generally, not just about ant classes.
>

I actually thought that functionality had been implemented a long time ago,  
but obviously my memory is failing me....

Another example is servlet-api.