perl-module.eclass -- review

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

perl-module.eclass -- review

Torsten Veller-3
Please review the attached perl-module.eclass.
Patch linked below.

Changes (#239510):
~~~~~~~
- EAPI 2 support
- default license
- reduced EXPORT_FUNCTIONS for EAPI=2
- HOMEPAGE changed
- LDFLAGS support
- quoting
- removes updatepod()
- removes .packlist files
- removes empty *.bs files
- removed BUILDER_VER stuff


IDEAS
~~~~~
- remove esvn_clean
- cache perlinfo calls


TODO (no showstopper)
~~~~
- still no documentation
- perl-app.eclass not done


After that perl-module_src_prep calls in ebuilds should be updated
(perl-module_src_configure) or removed:
|    app-pda/pilot-link
|    dev-perl/GDTextUtil
|    dev-tex/html2latex
|    kde-base/dcopperl
|    mail-filter/spamassassin
|    sci-libs/gdal
|    sci-libs/udunit

Ebuilds with a local perl-module_src_prep function should be fixed too
|    dev-perl/Alien-wxWidgets
|    dev-perl/HTML-Mason
|    www-apps/Embperl/Embperl


git://github.com/tove/perl-eclass.git
http://people.gentoo.org/tove/files/perl-module.eclass.diff

perl-module.eclass (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: perl-module.eclass -- review - 2

Torsten Veller-3
* Torsten Veller <[hidden email]>:
> Please review the attached perl-module.eclass.
> Patch linked below.

Thanks Bo ├śrsted Andresen for feedback

> Changes
> ~~~~~~~
  - use emake
  - more quoting
  - call perlinfo only once

As I've not seen any ebuild doing the replacement in line 156,
I've added a temporary ewarn. If you hits you, tell me.

> git://github.com/tove/perl-eclass.git
> http://people.gentoo.org/tove/files/perl-module.eclass.diff

perl-module.eclass (5K) Download Attachment